Bug: Likes not shown in private notebook

[mootari]

Steps:

1. Publish a notebook.
2. Receive like.
3. Unpublish notebook.

Expected result:
Like is shown in notebook detail.

Actual result:
Like is only shown in notebook teaser, not in notebook detail.

[mootari]

Unpublishing a notebook also removes assigned collections (only tested with a public collection).

[mbostock]

Removing a notebook from its collections on unpublish is a bug (now that we support private collections and private notebooks in public collections).

It’s expected behavior to not show likes on private notebooks—those are only for shared and public notebooks. So we shouldn’t be showing the likes in the notebook listing, either.

Thanks for the reports!

[mootari]

@mbostock

It’s expected behavior to not show likes on private notebooks—those are only for shared and public notebooks. So we shouldn’t be showing the likes in the notebook listing, either.

Why though? I would think that treating private notebooks differently increases the maintenance burden (as demonstrated by this bug), and @tom mentioned bookmarking as a valid use of self likes:

@bumbeishvili

Just interested, what is the reasoning behind letting people like their own notebooks?

(Or is there any?)

@tom

In short, some folks like to, and some people use likes as bookmarks, so it makes sense for them to be able to ‘bookmark’ their own content, the same way they can like their own tweets or start their own GitHub repositories.

[jashkenas]

@mootari

Unpublishing a notebook also removes assigned collections (only tested with a public collection).

This should be fixed now. Thanks, @mootari!